mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-13 01:33:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add comment explaining LLVM bug and linking tracking issue

Browse Source
This commit is contained in:
antlilja 2024-03-03 02:28:24 +01:00
parent d345068ec2
commit 282b398f6d
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/zig_llvm.cpp
View File

@ -384,6 +384,11 @@ struct ZigDiagnosticHandler : public DiagnosticHandler {
bool BrokenDebugInfo; bool BrokenDebugInfo;
ZigDiagnosticHandler() : BrokenDebugInfo(false) {} ZigDiagnosticHandler() : BrokenDebugInfo(false) {}
bool handleDiagnostics(const DiagnosticInfo &DI) override { bool handleDiagnostics(const DiagnosticInfo &DI) override {
// This dyn_cast should be casting to DiagnosticInfoIgnoringInvalidDebugMetadata
// but DiagnosticInfoIgnoringInvalidDebugMetadata is treated as DiagnosticInfoDebugMetadataVersion
// because of a bug in LLVM (see https://github.com/ziglang/zig/issues/19161).
// After this is fixed add an additional check for DiagnosticInfoIgnoringInvalidDebugMetadata
// but don't remove the current one as both indicate that debug info is broken.
if (auto *Remark = dyn_cast<DiagnosticInfoDebugMetadataVersion>(&DI)) { if (auto *Remark = dyn_cast<DiagnosticInfoDebugMetadataVersion>(&DI)) {
BrokenDebugInfo = true; BrokenDebugInfo = true;
} }