mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-13 12:59:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

std.tar: remove abuse of inline fn

Browse Source 
In general, any `inline fn` should document why it is using `inline`
because the rule of thumb is: don't use inline.
This commit is contained in:
Andrew Kelley 2024-02-22 15:45:07 -07:00
parent 30f15e3afe
commit 256c5934bf
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/std/tar.zig
View File

@ -299,14 +299,14 @@ fn Iterator(comptime ReaderType: type) type {
return header;
}
inline fn readString(self: *Self, size: usize, buffer: []u8) ![]const u8 {
fn readString(self: *Self, size: usize, buffer: []u8) ![]const u8 {
if (size > buffer.len) return error.TarCorruptInput;
const buf = buffer[0..size];
try self.reader.readNoEof(buf);
return nullStr(buf);
}
inline fn initFile(self: *Self) void {
fn initFile(self: *Self) void {
self.file = File{
.name = self.file_name_buffer[0..0],
.link_name = self.link_name_buffer[0..0],
@ -318,7 +318,7 @@ fn Iterator(comptime ReaderType: type) type {
}
// Number of padding bytes in the last file block.
inline fn blockPadding(size: u64) usize {
fn blockPadding(size: u64) usize {
const block_rounded = std.mem.alignForward(u64, size, Header.SIZE); // size rounded to te block boundary
return @intCast(block_rounded - size);
}
@ -498,22 +498,22 @@ fn PaxIterator(comptime ReaderType: type) type {
return null;
}
inline fn readUntil(self: *Self, delimiter: u8) ![]const u8 {
fn readUntil(self: *Self, delimiter: u8) ![]const u8 {
var fbs = std.io.fixedBufferStream(&self.scratch);
try self.reader.streamUntilDelimiter(fbs.writer(), delimiter, null);
return fbs.getWritten();
}
inline fn eql(a: []const u8, b: []const u8) bool {
fn eql(a: []const u8, b: []const u8) bool {
return std.mem.eql(u8, a, b);
}
inline fn hasNull(str: []const u8) bool {
fn hasNull(str: []const u8) bool {
return (std.mem.indexOfScalar(u8, str, 0)) != null;
}
// Checks that each record ends with new line.
inline fn validateAttributeEnding(reader: ReaderType) !void {
fn validateAttributeEnding(reader: ReaderType) !void {
if (try reader.readByte() != '\n') return error.PaxInvalidAttributeEnd;
}
};