mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-12-07 14:53:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

std.mem.asBytes: fix footgun when passing non-single pointer

Browse Source 
I was just bitten by this footgun, where I actually wanted
`sliceAsBytes` but unintentionally used `asBytes`, which in practice
ignored all but the first element. Just add a comptime assertion to
trigger a compile error in this case.
This commit is contained in:
mlugg 2024-10-31 02:32:34 +00:00
parent d11bbde5f9
commit 24babde746
No known key found for this signature in database
GPG Key ID: 3F5B7DCCBF4AF02E
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/std/mem.zig
View File

@ -3965,7 +3965,9 @@ fn CopyPtrAttrs(
} }
fn AsBytesReturnType(comptime P: type) type { fn AsBytesReturnType(comptime P: type) type {
const size = @sizeOf(std.meta.Child(P)); const pointer = @typeInfo(P).pointer;
assert(pointer.size == .One);
const size = @sizeOf(pointer.child);
return CopyPtrAttrs(P, .One, [size]u8); return CopyPtrAttrs(P, .One, [size]u8);
} }