mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-14 13:30:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't ptrCast a result-location assignment to _

Browse Source 
After #4010 doing `_ = @bitCast(...)` triggered a nonsensical compiler
error.
This commit is contained in:
LemonBoy 2020-01-02 12:56:46 +01:00 committed by Andrew Kelley
parent f35a963ac5
commit 1e61e5f404
2 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/ir.cpp
View File

@ -17394,11 +17394,23 @@ static IrInstruction *ir_resolve_result_raw(IrAnalyze *ira, IrInstruction *suspe
}
ZigType *parent_ptr_type = parent_result_loc->value->type;
assert(parent_ptr_type->id == ZigTypeIdPointer);
if ((err = type_resolve(ira->codegen, parent_ptr_type->data.pointer.child_type,
ResolveStatusAlignmentKnown)))
{
ZigType *child_type = parent_ptr_type->data.pointer.child_type;
bool has_bits;
if ((err = type_has_bits2(ira->codegen, child_type, &has_bits))) {
return ira->codegen->invalid_instruction;
}
// This happens when the bitCast result is assigned to _
if (!has_bits) {
assert(allow_discard);
return parent_result_loc;
}
if ((err = type_resolve(ira->codegen, child_type, ResolveStatusAlignmentKnown))) {
return ira->codegen->invalid_instruction;
}
uint64_t parent_ptr_align = get_ptr_align(ira->codegen, parent_ptr_type);
if ((err = type_resolve(ira->codegen, value_type, ResolveStatusAlignmentKnown))) {
return ira->codegen->invalid_instruction;

4
test/stage1/behavior/bitcast.zig
View File

@ -146,3 +146,7 @@ test "comptime bitcast used in expression has the correct type" {
};
expect(@bitCast(u8, Foo{ .value = 0xF }) == 0xf);
}
test "bitcast result to _" {
_ = @bitCast(u8, @as(i8, 1));
}