sema: add compile error for duplicate union field

This commit is contained in:
John Schmidt 2022-04-03 14:01:06 +02:00
parent fd1ce329b3
commit 174a889364
2 changed files with 31 additions and 1 deletions

View File

@ -22215,7 +22215,22 @@ fn semaUnionFields(block: *Block, mod: *Module, union_obj: *Module.Union) Compil
}
const gop = union_obj.fields.getOrPutAssumeCapacity(field_name);
assert(!gop.found_existing);
if (gop.found_existing) {
const msg = msg: {
const tree = try sema.getAstTree(&block_scope);
const field_src = enumFieldSrcLoc(decl, tree.*, union_obj.node_offset, field_i);
const msg = try sema.errMsg(&block_scope, field_src, "duplicate union field: '{s}'", .{field_name});
errdefer msg.destroy(gpa);
const prev_field_index = union_obj.fields.getIndex(field_name).?;
const prev_field_src = enumFieldSrcLoc(decl, tree.*, union_obj.node_offset, prev_field_index);
try sema.mod.errNoteNonLazy(prev_field_src.toSrcLoc(decl), msg, "other field here", .{});
try sema.errNote(&block_scope, src, msg, "union declared here", .{});
break :msg msg;
};
return sema.failWithOwnedErrorMsg(&block_scope, msg);
}
gop.value_ptr.* = .{
.ty = try field_ty.copy(decl_arena_allocator),
.abi_align = 0,

View File

@ -0,0 +1,15 @@
const U = union {
foo: u32,
foo: u32,
};
export fn entry() void {
const u: U = .{ .foo = 100 };
_ = u;
}
// duplicate union field name
//
// :3:5: error: duplicate union field: 'foo'
// :2:5: note: other field here
// :1:11: note: union declared here