mirror/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2026-02-21 16:54:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

add compile error when setting non power of 2 alignment

Browse Source
This commit is contained in:
Andrew Kelley 2017-02-04 10:38:28 -05:00
parent 0919ea0afd
commit 0d7abc6368
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ir.cpp
View File

@ -9451,6 +9451,10 @@ static TypeTableEntry *ir_analyze_instruction_set_fn_visible(IrAnalyze *ira,
return ira->codegen->builtin_types.entry_void;
}
static bool is_power_of_2(uint64_t x) {
return x != 0 && ((x & (~x + 1)) == x);
}
static TypeTableEntry *ir_analyze_instruction_set_global_align(IrAnalyze *ira,
IrInstructionSetGlobalAlign *instruction)
{
@ -9461,7 +9465,10 @@ static TypeTableEntry *ir_analyze_instruction_set_global_align(IrAnalyze *ira,
if (!ir_resolve_usize(ira, align_value, &scalar_align))
return ira->codegen->builtin_types.entry_invalid;
// TODO error if not power of 2
if (!is_power_of_2(scalar_align)) {
ir_add_error(ira, instruction->value, buf_sprintf("alignment value must be power of 2"));
return ira->codegen->builtin_types.entry_invalid;
}
AstNode *source_node = instruction->base.source_node;
if (tld_var->set_global_align_node) {

7
test/run_tests.cpp
View File

@ -1662,6 +1662,13 @@ fn foo() {
}
)SOURCE", 1, ".tmp_source.zig:3:24: error: integer value 753664 cannot be implicitly casted to type 'u16'");
add_compile_fail_case("set global variable alignment to non power of 2", R"SOURCE(
const some_data: [100]u8 = {
@setGlobalAlign(some_data, 3);
undefined
};
)SOURCE", 1, ".tmp_source.zig:3:32: error: alignment value must be power of 2");
}
//////////////////////////////////////////////////////////////////////////////