From 055023efb474acb4a2ff05b28d66a72f3805e34a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Prokop=20Rand=C3=A1=C4=8Dek?= <prokop@rdck.dev>
Date: Tue, 26 Mar 2024 13:00:13 +0100
Subject: [PATCH] valgrind client request wrappers take const pointers (#19237)

* valgrind client request wrappers take const pointers

* require zero terminated strings in valgrind wrappers
---
 lib/std/valgrind/callgrind.zig |  2 +-
 lib/std/valgrind/memcheck.zig  | 14 +++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/lib/std/valgrind/callgrind.zig b/lib/std/valgrind/callgrind.zig
index 3ba74fb525..ded2d3661a 100644
--- a/lib/std/valgrind/callgrind.zig
+++ b/lib/std/valgrind/callgrind.zig
@@ -27,7 +27,7 @@ pub fn dumpStats() void {
 /// The argument is appended to a string stating the reason which triggered
 /// the dump. This string is written as a description field into the
 /// profile data dump.
-pub fn dumpStatsAt(pos_str: [*]u8) void {
+pub fn dumpStatsAt(pos_str: [*:0]const u8) void {
     doCallgrindClientRequestStmt(.DumpStatsAt, @intFromPtr(pos_str), 0, 0, 0, 0);
 }
 
diff --git a/lib/std/valgrind/memcheck.zig b/lib/std/valgrind/memcheck.zig
index b9d321210a..e66943ee2c 100644
--- a/lib/std/valgrind/memcheck.zig
+++ b/lib/std/valgrind/memcheck.zig
@@ -29,19 +29,19 @@ fn doMemCheckClientRequestStmt(request: MemCheckClientRequest, a1: usize, a2: us
 }
 
 /// Mark memory at qzz.ptr as unaddressable for qzz.len bytes.
-pub fn makeMemNoAccess(qzz: []u8) void {
+pub fn makeMemNoAccess(qzz: []const u8) void {
     _ = doMemCheckClientRequestExpr(0, // default return
         .MakeMemNoAccess, @intFromPtr(qzz.ptr), qzz.len, 0, 0, 0);
 }
 
 /// Mark memory at qzz.ptr as addressable but undefined for qzz.len bytes.
-pub fn makeMemUndefined(qzz: []u8) void {
+pub fn makeMemUndefined(qzz: []const u8) void {
     _ = doMemCheckClientRequestExpr(0, // default return
         .MakeMemUndefined, @intFromPtr(qzz.ptr), qzz.len, 0, 0, 0);
 }
 
 /// Mark memory at qzz.ptr as addressable and defined or qzz.len bytes.
-pub fn makeMemDefined(qzz: []u8) void {
+pub fn makeMemDefined(qzz: []const u8) void {
     _ = doMemCheckClientRequestExpr(0, // default return
         .MakeMemDefined, @intFromPtr(qzz.ptr), qzz.len, 0, 0, 0);
 }
@@ -49,7 +49,7 @@ pub fn makeMemDefined(qzz: []u8) void {
 /// Similar to makeMemDefined except that addressability is
 /// not altered: bytes which are addressable are marked as defined,
 /// but those which are not addressable are left unchanged.
-pub fn makeMemDefinedIfAddressable(qzz: []u8) void {
+pub fn makeMemDefinedIfAddressable(qzz: []const u8) void {
     _ = doMemCheckClientRequestExpr(0, // default return
         .MakeMemDefinedIfAddressable, @intFromPtr(qzz.ptr), qzz.len, 0, 0, 0);
 }
@@ -58,7 +58,7 @@ pub fn makeMemDefinedIfAddressable(qzz: []u8) void {
 /// string which is included in any messages pertaining to addresses
 /// within the specified memory range.  Has no other effect on the
 /// properties of the memory range.
-pub fn createBlock(qzz: []u8, desc: [*]u8) usize {
+pub fn createBlock(qzz: []const u8, desc: [*:0]const u8) usize {
     return doMemCheckClientRequestExpr(0, // default return
         .CreateBlock, @intFromPtr(qzz.ptr), qzz.len, @intFromPtr(desc), 0, 0);
 }
@@ -74,7 +74,7 @@ pub fn discard(blkindex: usize) bool {
 /// If suitable addressability is not established, Valgrind prints an
 /// error message and returns the address of the first offending byte.
 /// Otherwise it returns zero.
-pub fn checkMemIsAddressable(qzz: []u8) usize {
+pub fn checkMemIsAddressable(qzz: []const u8) usize {
     return doMemCheckClientRequestExpr(0, .CheckMemIsAddressable, @intFromPtr(qzz.ptr), qzz.len, 0, 0, 0);
 }
 
@@ -82,7 +82,7 @@ pub fn checkMemIsAddressable(qzz: []u8) usize {
 /// qzz.len bytes.  If suitable addressability and definedness are not
 /// established, Valgrind prints an error message and returns the
 /// address of the first offending byte.  Otherwise it returns zero.
-pub fn checkMemIsDefined(qzz: []u8) usize {
+pub fn checkMemIsDefined(qzz: []const u8) usize {
     return doMemCheckClientRequestExpr(0, .CheckMemIsDefined, @intFromPtr(qzz.ptr), qzz.len, 0, 0, 0);
 }