From 007eb3bd714caee550722cae0e4e98a205ead341 Mon Sep 17 00:00:00 2001 From: Jakub Konka Date: Wed, 3 Aug 2022 21:26:52 +0200 Subject: [PATCH] macho: fix some TODOs --- src/link/MachO.zig | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/link/MachO.zig b/src/link/MachO.zig index a955200a77..db207af5f5 100644 --- a/src/link/MachO.zig +++ b/src/link/MachO.zig @@ -64,7 +64,10 @@ const SystemLib = struct { const Section = struct { header: macho.section_64, segment_index: u8, - last_atom: ?*Atom = null, // TODO temporary hack; we really should shrink section to 0 + + // TODO is null here necessary, or can we do away with tracking via section + // size in incremental context? + last_atom: ?*Atom = null, /// A list of atoms that have surplus capacity. This list can have false /// positives, as functions grow and shrink over time, only sometimes being added @@ -4434,8 +4437,8 @@ fn initSection( } header.addr = seg.vmaddr + off - seg.fileoff; - // TODO this will break if we are inserting section that is not the last section - // in a segment. + // TODO Will this break if we are inserting section that is not the last section + // in a segment? const max_size = self.allocatedSize(segment_id, off); if (size > max_size) {